Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_controller.h

Issue 1185723002: Prepare HistoryProvider for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "base/timer/timer.h" 14 #include "base/timer/timer.h"
15 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
15 #include "components/omnibox/autocomplete_input.h" 16 #include "components/omnibox/autocomplete_input.h"
16 #include "components/omnibox/autocomplete_provider.h" 17 #include "components/omnibox/autocomplete_provider.h"
17 #include "components/omnibox/autocomplete_provider_listener.h" 18 #include "components/omnibox/autocomplete_provider_listener.h"
18 #include "components/omnibox/autocomplete_result.h" 19 #include "components/omnibox/autocomplete_result.h"
19 20
20 class AutocompleteControllerDelegate; 21 class AutocompleteControllerDelegate;
21 class HistoryURLProvider; 22 class HistoryURLProvider;
22 class KeywordProvider; 23 class KeywordProvider;
23 class Profile; 24 class Profile;
24 class SearchProvider; 25 class SearchProvider;
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 Providers providers_; 210 Providers providers_;
210 211
211 HistoryURLProvider* history_url_provider_; 212 HistoryURLProvider* history_url_provider_;
212 213
213 KeywordProvider* keyword_provider_; 214 KeywordProvider* keyword_provider_;
214 215
215 SearchProvider* search_provider_; 216 SearchProvider* search_provider_;
216 217
217 ZeroSuggestProvider* zero_suggest_provider_; 218 ZeroSuggestProvider* zero_suggest_provider_;
218 219
220 // The client passed to the providers.
221 scoped_ptr<ChromeAutocompleteProviderClient> provider_client_;
Peter Kasting 2015/06/16 00:03:42 Nit: I'd place this above |providers_| since it ou
blundell 2015/06/16 07:21:25 Done.
222
219 // Input passed to Start. 223 // Input passed to Start.
220 AutocompleteInput input_; 224 AutocompleteInput input_;
221 225
222 // Data from the autocomplete query. 226 // Data from the autocomplete query.
223 AutocompleteResult result_; 227 AutocompleteResult result_;
224 228
225 // The most recent time the default match (inline match) changed. This may 229 // The most recent time the default match (inline match) changed. This may
226 // be earlier than the most recent keystroke if the recent keystrokes didn't 230 // be earlier than the most recent keystroke if the recent keystrokes didn't
227 // change the suggested match in the omnibox. (For instance, if 231 // change the suggested match in the omnibox. (For instance, if
228 // a user typed "mail.goog" and the match https://mail.google.com/ was 232 // a user typed "mail.goog" and the match https://mail.google.com/ was
(...skipping 25 matching lines...) Expand all
254 // Are we in Start()? This is used to avoid updating |result_| and sending 258 // Are we in Start()? This is used to avoid updating |result_| and sending
255 // notifications until Start() has been invoked on all providers. 259 // notifications until Start() has been invoked on all providers.
256 bool in_start_; 260 bool in_start_;
257 261
258 TemplateURLService* template_url_service_; 262 TemplateURLService* template_url_service_;
259 263
260 DISALLOW_COPY_AND_ASSIGN(AutocompleteController); 264 DISALLOW_COPY_AND_ASSIGN(AutocompleteController);
261 }; 265 };
262 266
263 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 267 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698