Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1185703006: Build ARM SZ runtime files. Use le32-nacl-objcopy in various places. (Closed)

Created:
5 years, 6 months ago by jvoung (off chromium)
Modified:
5 years, 6 months ago
Reviewers:
Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, reed.kotler
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build ARM SZ runtime files. Use le32-nacl-objcopy in various places. Use PNaCl built binutils, which is known to support ARM and MIPS. Otherwise the system-provided binutils may or may not have that support (mine did not and perhaps expected a prefix like arm-xxx-objcopy for the version that did support arm). Split off from CL to run crosstests for ARM under qemu. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=050deaa685be123c418a33cb89100d8b77f2eaf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -44 lines) Patch
M Makefile.standalone View 1 chunk +2 lines, -1 line 0 comments Download
M pydir/build-runtime.py View 4 chunks +59 lines, -28 lines 0 comments Download
M pydir/crosstest.py View 1 chunk +2 lines, -1 line 0 comments Download
M pydir/szbuild.py View 4 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 6 months ago (2015-06-12 21:26:46 UTC) #2
John
lgtm
5 years, 6 months ago (2015-06-12 21:36:18 UTC) #3
Jim Stichnoth
lgtm
5 years, 6 months ago (2015-06-12 21:48:14 UTC) #4
jvoung (off chromium)
5 years, 6 months ago (2015-06-12 22:12:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
050deaa685be123c418a33cb89100d8b77f2eaf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698