Add constant blinding/pooling option for X8632 code translation

src/IceClFlags.h

 //===- subzero/src/IceClFlags.h - Cl Flags for translation ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares command line flags controlling translation.
@@ skipping 158 matching lines @@
 
   size_t getNumTranslationThreads() const { return NumTranslationThreads; }
   bool isSequential() const { return NumTranslationThreads == 0; }
   void setNumTranslationThreads(size_t NewValue) {
     NumTranslationThreads = NewValue;
   }
 
   uint64_t getRandomSeed() const { return RandomSeed; }
   void setRandomSeed(size_t NewValue) { RandomSeed = NewValue; }
 
+  // Immediates Randomization and Pooling options getter and setter
+  void setRandomizeAndPoolImmediatesOption(
+      Ice::RandomizeAndPoolImmediatesEnum option) {

[Jim Stichnoth, 2015/06/12 23:48:17]

capitalize Option per LLVM coding conventions

[qining, 2015/06/17 04:28:53]

Done.

+    RandomizeAndPoolImmediatesOption = option;
+  }
+  bool shouldRandomizeImmediates() const {

[Jim Stichnoth, 2015/06/12 23:48:16]

I think it would be better to have a single getRandomizeImmediates() method
instead of a bunch of bool getters.  There are other getters here that return an
enum type, e.g. getOptLevel(), getOutFileType(), getTargetArch(), getVerbose(),
etc.

[qining, 2015/06/17 04:28:53]

Done.

+    return RandomizeAndPoolImmediatesOption == Ice::RandomizeImmediates;
+  }
+  bool shouldPoolImmediates() const {
+    return RandomizeAndPoolImmediatesOption == Ice::PoolImmediates;
+  }
+  bool shouldNotRandomizeOrPoolImmediates() const {
+    return RandomizeAndPoolImmediatesOption ==
+           Ice::NoneImmediatesRandomizationPooling;

[Jim Stichnoth, 2015/06/12 23:48:17]

I don't think you need "Ice::" here and above since you're already in the Ice
namespace.

[qining, 2015/06/17 04:28:53]

Done.

+  }
+
 private:
   bool AllowErrorRecovery;
   bool AllowUninitializedGlobals;
   bool DataSections;
   bool DecorateAsm;
   bool DisableInternal;
   bool DisableIRGeneration;
   bool DisableTranslation;
   bool DumpStats;
   bool EnableBlockProfile;
@@ skipping 15 matching lines @@
   TargetInstructionSet TInstrSet;
   VerboseMask VMask;
 
   IceString DefaultFunctionPrefix;
   IceString DefaultGlobalPrefix;
   IceString TestPrefix;
   IceString TimingFocusOn;
   IceString TranslateOnly;
   IceString VerboseFocusOn;
 
+  // Immediates Randomization and Pooling options
+  RandomizeAndPoolImmediatesEnum RandomizeAndPoolImmediatesOption;
+
   size_t NumTranslationThreads; // 0 means completely sequential
   uint64_t RandomSeed;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICECLFLAGS_H