Issue 11857014: Move android reboot step into python

Issue 11857014: Move android reboot step into python (Closed)

Created:
7 years, 11 months ago by Isaac (away)

Modified:
7 years, 11 months ago

Reviewers:
xusydoc (do not use), bulach, Mike Stip (use stip instead)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move android reboot step into python This should move the last dependence on adb out of buildbot_functions. Also includes various other android buildbot fixes: - Start logcat monitor before reboot command to catch JB crash. - Rename bb_tests to bb_device_steps. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176651

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -296 lines)			Patch
M	build/android/PRESUBMIT.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	build/android/buildbot/bb_device_steps.py	View	1 2 3	10 chunks	+67 lines, -15 lines	0 comments	Download
M	build/android/buildbot/bb_run_bot.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
D	build/android/buildbot/bb_tests.py	View		1 chunk	+0 lines, -258 lines	0 comments	Download
M	build/android/buildbot/buildbot_functions.sh	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm but I'm not too familiar with this new structure, please let mike have a ...

7 years, 11 months ago (2013-01-14 09:44:43 UTC) #2

Isaac (away)

Don't think there's anyone really familiar with this besides me, unfortunately.

7 years, 11 months ago (2013-01-14 09:57:16 UTC) #3

Isaac (away)

7 years, 11 months ago (2013-01-14 10:37:27 UTC) #5

Message was sent while issue was closed.

dcommitted as r176651.

https://chromiumcodereview.appspot.com/11857014/diff/15001/build/android/buil...
File build/android/buildbot/bb_device_steps.py (right):

https://chromiumcodereview.appspot.com/11857014/diff/15001/build/android/buil...
build/android/buildbot/bb_device_steps.py:89: # This has to be a static function
due to multiprocessing pickiness
On 2013/01/14 09:44:43, bulach wrote:
> nit: for future readers, how about:
> 
> # Multiprocessing.map_async requires a public top-level function.

Done.

Expand Messages | Collapse Messages