Issue 11857008: Remove InputMethodLookupTable and use IBusLookupTable instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11857008: Remove InputMethodLookupTable and use IBusLookupTable instead. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka

Modified:
7 years, 11 months ago

Reviewers:
satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove InputMethodLookupTable and use IBusLookupTable instead. This is part of cleaning up of ibus_ui_controller removal. InputMethodLookupTable is used as Chrome representation of IBusLookupTable in libibus C structure, but now libibus was gone and ibus::IBusLookupTable can be used instead. So InputMethodLookupTable is no longer necessary. BUG=None TEST=ran unit_tests, ui_unittests, chromeos_unittests and manually checked that there is no UI change with lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177108

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -488 lines)			Patch
M	chrome/browser/chromeos/input_method/candidate_view.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl.h	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc	View	3 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl_unittest.cc	View	4 chunks	+36 lines, -34 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.h	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.cc	View	27 chunks	+75 lines, -94 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc	View	10 chunks	+76 lines, -223 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_ui_controller.h	View	3 chunks	+3 lines, -55 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_ui_controller.cc	View	2 chunks	+1 line, -63 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11857008/1

7 years, 11 months ago (2013-01-16 05:44:37 UTC) #3

Message was sent while issue was closed.

Change committed as 177108

Expand Messages | Collapse Messages