scripts/slave/recipes/chromium_gn.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Address review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromium_gn.py

diff --git a/scripts/slave/recipes/chromium_gn.py b/scripts/slave/recipes/chromium_gn.py

index 6306182b963039d64198fc96c5f482fe7deea730..29a9aaef5625973d21834b8392de0cdb61119e36 100644

--- a/scripts/slave/recipes/chromium_gn.py

+++ b/scripts/slave/recipes/chromium_gn.py

@@ -458,12 +458,12 @@ def _GenStepsInternal(api):

test_spec_file = '%s.json' % mastername

test_spec = api.chromium_tests.read_test_spec(api, test_spec_file)

- tests = list(api.chromium.steps.generate_gtest(

+ tests = list(api.chromium_tests.steps.generate_gtest(

api, mastername, buildername, test_spec))

scripts_compile_targets = \

- api.chromium.get_compile_targets_for_scripts().json.output

- tests += list(api.chromium.steps.generate_script(

+ api.chromium_tests.get_compile_targets_for_scripts().json.output

+ tests += list(api.chromium_tests.steps.generate_script(

api, mastername, buildername, test_spec,

scripts_compile_targets=scripts_compile_targets))

« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »