Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: scripts/slave/recipe_modules/chromium/client_skia.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Address review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/client_skia.py
diff --git a/scripts/slave/recipe_modules/chromium/client_skia.py b/scripts/slave/recipe_modules/chromium/client_skia.py
deleted file mode 100644
index 2f9e1a1907de129e9f030b1b0f5b913958ae0b34..0000000000000000000000000000000000000000
--- a/scripts/slave/recipe_modules/chromium/client_skia.py
+++ /dev/null
@@ -1,45 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import copy
-import os
-import sys
-
-from . import chromium_linux
-from . import chromium_mac
-from . import chromium_win
-
-# TODO(luqui): Separate the skia common scripts out so we can make this
-# independent of build/.
-sys.path.append(
- os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(
- os.path.abspath(__file__))))))
-from common.skia import builder_name_schema
-
-# The Skia config just clones some regular Chromium builders, except that they
-# use an up-to-date Skia.
-
-# This list specifies which Chromium builders to "copy".
-_builders = [
-# SPEC Module Test Spec File Builder Names
- (chromium_linux, 'chromium.linux.json', ['Linux Builder', 'Linux Tests']),
- (chromium_win, 'chromium.win.json', ['Win Builder', 'Win7 Tests (1)']),
- (chromium_mac, 'chromium.mac.json', ['Mac Builder', 'Mac10.9 Tests']),
-]
-
-SPEC = {
- 'settings': {
- 'build_gs_bucket': 'chromium-skia-gm',
- },
- 'builders': {},
-}
-
-for spec_module, test_spec_file, builders_list in _builders:
- for builder in builders_list:
- for builder_name in (builder, builder_name_schema.TrybotName(builder)):
- builder_cfg = copy.deepcopy(spec_module.SPEC['builders'][builder])
- builder_cfg['gclient_config'] = 'chromium_skia'
- builder_cfg['testing']['test_spec_file'] = test_spec_file
- builder_cfg['patch_root'] = 'src/third_party/skia'
- SPEC['builders'][builder_name] = builder_cfg
« no previous file with comments | « scripts/slave/recipe_modules/chromium/chromium_win.py ('k') | scripts/slave/recipe_modules/chromium/client_v8_fyi.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698