scripts/slave/recipes/chromium.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Add builders property to chromium_tests test_api. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromium.py

diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py

index 06c824e1d9f9a62e1493676d5b4d8e7a90b4fedd..ba815479da318bf8fa56fb847cea6f8fe27045e4 100644

--- a/scripts/slave/recipes/chromium.py

+++ b/scripts/slave/recipes/chromium.py

@@ -24,6 +24,7 @@ DEPS = [

def GenSteps(api):

mastername = api.properties.get('mastername')

buildername = api.properties.get('buildername')

+ api.chromium_tests.load_builder_configs(mastername)

if mastername == 'tryserver.chromium.perf' and api.chromium.builders[

mastername]['builders'][buildername]['bot_type'] == 'tester':

@@ -52,7 +53,8 @@ def _sanitize_nonalpha(text):

def GenTests(api):

- for mastername, master_config in api.chromium.builders.iteritems():

+ # TODO(akuegel): Filter out those masters that are not using this recipe.

Paweł Hajdan Jr. 2015/06/15 09:09:29 Well, I'd say these masters just shouldn't be in c

Adrian Kuegel 2015/06/15 12:33:22 Acknowledged. I removed this TODO.

+ for mastername, master_config in api.chromium_tests.builders.iteritems():

# parent builder name -> list of triggered builders.

triggered_by_parent = {}

« scripts/slave/recipes/bisection/desktop_bisect.py ('K') | « scripts/slave/recipes/blink_trybot.py ('k') | scripts/slave/recipes/chromium_gn.py » ('j') | no next file with comments »