scripts/slave/recipes/android/perf.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/perf.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Add builders property to chromium_tests test_api. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_tests/api.py ('K') | « scripts/slave/recipe_modules/gpu/api.py ('k') | scripts/slave/recipes/bisect.py » ('j') | scripts/slave/recipes/bisect.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/perf.py

diff --git a/scripts/slave/recipes/android/perf.py b/scripts/slave/recipes/android/perf.py

index 365b87159259ea6a7c018300605829cb087c45f1..d0ac1af8a98dec8f90731e25793c6d82f29154b7 100644

--- a/scripts/slave/recipes/android/perf.py

+++ b/scripts/slave/recipes/android/perf.py

@@ -103,6 +103,7 @@ BUILDERS = freeze({

def GenSteps(api):

mastername = api.properties['mastername']

buildername = api.properties['buildername']

+ api.chromium_tests.load_builder_configs(mastername)

Paweł Hajdan Jr. 2015/06/15 09:09:29 This recipe should be using its own configs rather

Adrian Kuegel 2015/06/15 12:33:22 Done.

builder = thaw(BUILDERS[mastername][buildername])

api.chromium_android.set_config(

builder.get('recipe_config', 'base_config'), REPO_NAME='src',

@@ -139,7 +140,7 @@ def GenSteps(api):

builder['tests'] = api.chromium_tests.generate_tests_from_test_spec(

api, test_spec, builder, buildername, mastername, False,

- scripts_compile_targets, [api.chromium.steps.generate_script])

+ scripts_compile_targets, [api.chromium_tests.steps.generate_script])

api.path['checkout'] = api.path['slave_build'].join('src')

api.chromium_android.clean_local_files()

« scripts/slave/recipe_modules/chromium_tests/api.py ('K') | « scripts/slave/recipe_modules/gpu/api.py ('k') | scripts/slave/recipes/bisect.py » ('j') | scripts/slave/recipes/bisect.py » ('J')