Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: scripts/slave/recipes/blink_downstream.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Address review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 This recipe can be used by components like v8 to verify blink tests with a 6 This recipe can be used by components like v8 to verify blink tests with a
7 low false positive rate. Similar to a trybot, this recipe compares test 7 low false positive rate. Similar to a trybot, this recipe compares test
8 failures from a build with a current component revision with test failures 8 failures from a build with a current component revision with test failures
9 from a build with a pinned component revision. 9 from a build with a pinned component revision.
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 Revision Y will be the revision property as provided by buildbot or HEAD (i.e. 24 Revision Y will be the revision property as provided by buildbot or HEAD (i.e.
25 in a forced build with no revision provided). 25 in a forced build with no revision provided).
26 """ 26 """
27 27
28 from infra.libs.infra_types import freeze 28 from infra.libs.infra_types import freeze
29 29
30 DEPS = [ 30 DEPS = [
31 'bot_update', 31 'bot_update',
32 'chromium', 32 'chromium',
33 'chromium_tests',
33 'gclient', 34 'gclient',
34 'json', 35 'json',
35 'path', 36 'path',
36 'platform', 37 'platform',
37 'properties', 38 'properties',
38 'python', 39 'python',
39 'raw_io', 40 'raw_io',
40 'step', 41 'step',
41 'test_utils', 42 'test_utils',
42 ] 43 ]
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 api.chromium.compile() 126 api.chromium.compile()
126 127
127 extra_args = list(bot_config.get('test_args', [])) 128 extra_args = list(bot_config.get('test_args', []))
128 if bot_config.get('additional_expectations'): 129 if bot_config.get('additional_expectations'):
129 extra_args.extend([ 130 extra_args.extend([
130 '--additional-expectations', 131 '--additional-expectations',
131 api.path['checkout'].join(*bot_config['additional_expectations']), 132 api.path['checkout'].join(*bot_config['additional_expectations']),
132 ]) 133 ])
133 134
134 tests = [ 135 tests = [
135 api.chromium.steps.BlinkTest(extra_args=extra_args), 136 api.chromium_tests.steps.BlinkTest(extra_args=extra_args),
136 ] 137 ]
137 api.test_utils.determine_new_failures(api, tests, component_pinned_fn) 138 api.test_utils.determine_new_failures(api, tests, component_pinned_fn)
138 139
139 140
140 def _sanitize_nonalpha(text): 141 def _sanitize_nonalpha(text):
141 return ''.join(c if c.isalnum() else '_' for c in text) 142 return ''.join(c if c.isalnum() else '_' for c in text)
142 143
143 144
144 def GenTests(api): 145 def GenTests(api):
145 canned_test = api.test_utils.canned_test_output 146 canned_test = api.test_utils.canned_test_output
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 # and compare the lists of failing tests). 216 # and compare the lists of failing tests).
216 yield ( 217 yield (
217 api.test('too_many_failures_for_retcode') + 218 api.test('too_many_failures_for_retcode') +
218 properties('client.v8.fyi', 'V8-Blink Linux 64') + 219 properties('client.v8.fyi', 'V8-Blink Linux 64') +
219 api.override_step_data(with_patch, 220 api.override_step_data(with_patch,
220 canned_test(passing=False, 221 canned_test(passing=False,
221 num_additional_failures=125)) + 222 num_additional_failures=125)) +
222 api.override_step_data(without_patch, 223 api.override_step_data(without_patch,
223 canned_test(passing=True, minimal=True)) 224 canned_test(passing=True, minimal=True))
224 ) 225 )
OLDNEW
« no previous file with comments | « scripts/slave/recipes/bisection/desktop_bisect.py ('k') | scripts/slave/recipes/blink_trybot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698