scripts/slave/recipes/bisection/desktop_bisect.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/bisection/desktop_bisect.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Add builders property to chromium_tests test_api. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 DEPS = [	5 DEPS = [

6 'auto_bisect',	6 'auto_bisect',

7 'chromium_tests',	7 'chromium_tests',

8 'platform',	8 'platform',

9 'properties',	9 'properties',

10 ]	10 ]

11	11

12 def GenSteps(api):	12 def GenSteps(api):

13 mastername = api.properties.get('mastername')	13 mastername = api.properties.get('mastername')

14 buildername = api.properties.get('buildername')	14 buildername = api.properties.get('buildername')

	15 api.chromium_tests.load_builder_configs(mastername)
	Paweł Hajdan Jr. 2015/06/15 09:09:29 This recipe should be using its own configs rather This recipe should be using its own configs rather than the shared ones. Could you add at least a TODO to clean this up? Adrian Kuegel 2015/06/15 12:33:22 Done. Show quoted text On 2015/06/15 09:09:29, Paweł Hajdan Jr. wrote: > This recipe should be using its own configs rather than the shared ones. Could > you add at least a TODO to clean this up? Done.
15 api.chromium_tests.configure_build(mastername, buildername)	16 api.chromium_tests.configure_build(mastername, buildername)

16 api.chromium_tests.prepare_checkout(mastername, buildername)	17 api.chromium_tests.prepare_checkout(mastername, buildername)

17 api.auto_bisect.run_bisect_script()	18 api.auto_bisect.run_bisect_script()

18	19

19 def GenTests(api):	20 def GenTests(api):

20 yield (api.test('basic')	21 yield (api.test('basic')

21 +api.properties.tryserver(	22 +api.properties.tryserver(

22 mastername='tryserver.chromium.perf',	23 mastername='tryserver.chromium.perf',

23 buildername='linux_perf_bisect'))	24 buildername='linux_perf_bisect'))

OLD	NEW

« scripts/slave/recipes/bisect.py ('K') | « scripts/slave/recipes/bisect.py ('k') | scripts/slave/recipes/blink_downstream.py » ('j') | scripts/slave/recipes/chromium.py » ('J')