Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1185633003: cps-ir: Support foreign code. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Status file updates. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index d7f4b4514a05fd36134f995bb45d96d04617f8b6..2a07a9badcf07b107a8d8c37909f024e68ee17d3 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -338,6 +338,13 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String args = node.arguments.map(access).join(', ');
return '(CreateInvocationMirror $selector $args)';
}
+
+ @override
+ String visitForeignCode(ForeignCode node) {
+ String arguments = node.arguments.map(access).join(', ');
Kevin Millikin (Google) 2015/06/16 11:23:10 Arguments are just space separated.
karlklose 2015/06/18 09:38:14 Done.
+ String continuation = access(node.continuation);
+ return '(JS ${node.type} ${node.codeTemplate} $arguments $continuation)';
Kevin Millikin (Google) 2015/06/16 11:23:10 Arguments are enclosed in parentheses '($arguments
karlklose 2015/06/18 09:38:14 Done.
+ }
}
class ConstantStringifier extends ConstantValueVisitor<String, Null> {

Powered by Google App Engine
This is Rietveld 408576698