src/runtime/runtime-literals.cc - Issue 1185633002: Additional HandleScopes to limit Handle consumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-literals.cc

Issue 1185633002: Additional HandleScopes to limit Handle consumption. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Refine comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-literals.cc

diff --git a/src/runtime/runtime-literals.cc b/src/runtime/runtime-literals.cc

index 52c1726dc65ea256c1fafeb5d7eea890cf1f161f..80af962e3c9630111f91d56062554db67c8eb286 100644

--- a/src/runtime/runtime-literals.cc

+++ b/src/runtime/runtime-literals.cc

@@ -191,6 +191,7 @@ MaybeHandle<Object> Runtime::CreateArrayLiteralBoilerplate(

isolate->factory()->CopyFixedArray(fixed_array_values);

copied_elements_values = fixed_array_values_copy;

for (int i = 0; i < fixed_array_values->length(); i++) {

+ HandleScope scope(isolate);

if (fixed_array_values->get(i)->IsFixedArray()) {

// The value contains the constant_properties of a

// simple object or array literal.

« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-types.cc » ('j') | no next file with comments »