Issue 11856014: Adding support checks for FileSystem APIs and making APIs not webkit-specific.

Issue 11856014: Adding support checks for FileSystem APIs and making APIs not webkit-specific. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding support checks for FileSystem APIs and making APIs not webkit-specific. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16987

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -71 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+20 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+23 lines, -6 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View		2 chunks	+78 lines, -55 lines	0 comments	Download
M	tests/html/html.status	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1	3 chunks	+13 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/11856014/diff/1/tests/html/fileapi_test.dart File tests/html/fileapi_test.dart (right): https://codereview.chromium.org/11856014/diff/1/tests/html/fileapi_test.dart#newcode44 tests/html/fileapi_test.dart:44: test('getFileSystem', getFileSystem); this seems like the same test as ...

7 years, 11 months ago (2013-01-11 21:05:13 UTC) #2

blois

7 years, 11 months ago (2013-01-11 21:24:09 UTC) #3

Emily Fortuna

7 years, 11 months ago (2013-01-11 21:25:23 UTC) #4

lgtm

https://codereview.chromium.org/11856014/diff/1/tests/html/fileapi_test.dart
File tests/html/fileapi_test.dart (right):

https://codereview.chromium.org/11856014/diff/1/tests/html/fileapi_test.dart#...
tests/html/fileapi_test.dart:44: test('getFileSystem', getFileSystem);
gotcha.
On 2013/01/11 21:24:09, blois wrote:
> On 2013/01/11 21:05:13, Emily Fortuna wrote:
> > this seems like the same test as on line 33?
> 
> The tests rely on the FileSystem being fetched first (order-dependent tests,
not
> great).
> 
> Since the tests are now using the individual config, each group needs to get
the
> FS. Easiest to just make it a test to avoid too many levels of async in the
> other tests.

Expand Messages | Collapse Messages