Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc

Issue 1185593002: Move reusable part of LoginPolicyTestBase into a helper class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@key_perm
Patch Set: Addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/login_policy_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc b/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
index 814bbeea13a7a3b2c838b43d38913c74b5980c87..2cc37d5dfd745d024419f5d5a13ef3e94309b483 100644
--- a/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
+++ b/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
@@ -9,7 +9,6 @@
#include "ash/test/display_manager_test_api.h"
#include "ash/wm/window_positioner.h"
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
@@ -38,10 +37,8 @@ class ForceMaximizeOnFirstRunTest : public LoginPolicyTestBase,
set_use_webview(GetParam());
}
- scoped_ptr<base::DictionaryValue> GetMandatoryPoliciesValue() const override {
- scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
- dict->SetBoolean(key::kForceMaximizeOnFirstRun, true);
- return dict;
+ void GetMandatoryPoliciesValue(base::DictionaryValue* policy) const override {
+ policy->SetBoolean(key::kForceMaximizeOnFirstRun, true);
}
void SetUpResolution() {
@@ -109,10 +106,8 @@ class ForceMaximizePolicyFalseTest : public ForceMaximizeOnFirstRunTest {
protected:
ForceMaximizePolicyFalseTest() : ForceMaximizeOnFirstRunTest() {}
- scoped_ptr<base::DictionaryValue> GetMandatoryPoliciesValue() const override {
- scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
- dict->SetBoolean(key::kForceMaximizeOnFirstRun, false);
- return dict;
+ void GetMandatoryPoliciesValue(base::DictionaryValue* policy) const override {
+ policy->SetBoolean(key::kForceMaximizeOnFirstRun, false);
}
private:
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/login_policy_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698