Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2462)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

Issue 1185593002: Move reusable part of LoginPolicyTestBase into a helper class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@key_perm
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
index 0105d8813e5157bc02218b0ebad6c92e005325da..d529dcec6737b781800976422e4d066346fdbb47 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
@@ -26,17 +26,14 @@ class UserCloudPolicyManagerTest : public LoginPolicyTestBase,
set_use_webview(GetParam());
}
- scoped_ptr<base::DictionaryValue> GetMandatoryPoliciesValue() const override {
+ void GetMandatoryPoliciesValue(base::DictionaryValue* policy) const override {
scoped_ptr<base::ListValue> list(new base::ListValue);
list->AppendString("chrome://policy");
list->AppendString("chrome://about");
- scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
- dict->Set(key::kRestoreOnStartupURLs, list.Pass());
- dict->SetInteger(key::kRestoreOnStartup,
- SessionStartupPref::kPrefValueURLs);
-
- return dict;
+ policy->Set(key::kRestoreOnStartupURLs, list.Pass());
+ policy->SetInteger(key::kRestoreOnStartup,
+ SessionStartupPref::kPrefValueURLs);
}
private:

Powered by Google App Engine
This is Rietveld 408576698