Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1185573004: CSS Counters not properly updated on style changes (Closed)

Created:
5 years, 6 months ago by ramya.v
Modified:
5 years, 6 months ago
CC:
blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSS Counters not properly updated on style changes When oldstyle does not have counterDirectives and new style have counterDirectives on style change previous counter nodes were not cleared because of which oldstyle values are reflected. BUG=432598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197703

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updating as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutCounter.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ramya.v
PTAL! Thanks
5 years, 6 months ago (2015-06-12 13:28:29 UTC) #2
Timothy Loh
I'm not familiar with the counter code, maybe esprehn or jchaffraix would be able to ...
5 years, 6 months ago (2015-06-18 07:41:35 UTC) #4
esprehn
lgtm https://codereview.chromium.org/1185573004/diff/1/LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html File LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html (right): https://codereview.chromium.org/1185573004/diff/1/LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html#newcode3 LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html:3: <head> We usually leave out html, head and ...
5 years, 6 months ago (2015-06-19 22:51:50 UTC) #5
ramya.v
@esprehn, Updated as per review comments. PTAL! Thanks https://codereview.chromium.org/1185573004/diff/1/LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html File LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html (right): https://codereview.chromium.org/1185573004/diff/1/LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html#newcode3 LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html:3: <head> ...
5 years, 6 months ago (2015-06-22 04:04:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185573004/20001
5 years, 6 months ago (2015-06-24 04:24:30 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 05:44:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197703

Powered by Google App Engine
This is Rietveld 408576698