Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1185563002: Add --dump-line-box-trees parameter to content_shell. (Closed)

Created:
5 years, 6 months ago by szager1
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --dump-line-box-trees parameter to content_shell. This must land after: https://codereview.chromium.org/1180573003/ BUG=499644 Committed: https://crrev.com/cb4a4d87891508d830b6270bf3556c843c051949 Cr-Commit-Position: refs/heads/master@{#334557}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add braces to if one-liners. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M components/test_runner/web_test_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 1 chunk +14 lines, -5 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
szager1
5 years, 6 months ago (2015-06-12 02:04:49 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/1185563002/diff/1/content/shell/browser/shell_content_browser_client.cc File content/shell/browser/shell_content_browser_client.cc (right): https://codereview.chromium.org/1185563002/diff/1/content/shell/browser/shell_content_browser_client.cc#newcode232 content/shell/browser/shell_content_browser_client.cc:232: switches::kDumpLineBoxTrees)) Style nit: All of these multi-line `if` ...
5 years, 6 months ago (2015-06-12 07:27:22 UTC) #3
szager1
On 2015/06/12 07:27:22, Mike West wrote: > LGTM. > > https://codereview.chromium.org/1185563002/diff/1/content/shell/browser/shell_content_browser_client.cc > File content/shell/browser/shell_content_browser_client.cc (right): ...
5 years, 6 months ago (2015-06-16 05:54:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185563002/20001
5 years, 6 months ago (2015-06-16 05:54:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 06:32:46 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 06:33:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb4a4d87891508d830b6270bf3556c843c051949
Cr-Commit-Position: refs/heads/master@{#334557}

Powered by Google App Engine
This is Rietveld 408576698