Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: native_client_sdk/src/tools/tests/getos_test.py

Issue 118553007: [NaCl SDK] Use nacl_config.py in common.mk build system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tools/nacl_llvm.mk ('k') | native_client_sdk/src/tools/tests/nacl_config_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tools/tests/getos_test.py
diff --git a/native_client_sdk/src/tools/tests/getos_test.py b/native_client_sdk/src/tools/tests/getos_test.py
index b687d9190599f4be3461732761a031db29cd4ce5..498c52ac3622e4856d0bab6661954814e1a05827 100755
--- a/native_client_sdk/src/tools/tests/getos_test.py
+++ b/native_client_sdk/src/tools/tests/getos_test.py
@@ -91,33 +91,6 @@ class TestGetos(TestCaseExtended):
self.assertEqual(chrome, mock_location)
mock_exists.assert_called_with(chrome)
- def testGetHelperPath(self):
- """GetHelperPath checks that helper exists."""
- platform = getos.GetPlatform()
- # The helper is only needed on linux. On other platforms
- # GetHelperPath() simply return empty string.
- if platform == 'linux':
- with mock.patch('os.path.exists') as mock_exists:
- helper = getos.GetHelperPath(platform)
- mock_exists.assert_called_with(helper)
- else:
- helper = getos.GetHelperPath(platform)
- self.assertEqual(helper, '')
-
- def testGetIrtBinPath(self):
- """GetIrtBinPath checks that irtbin exists."""
- platform = getos.GetPlatform()
- with mock.patch('os.path.exists') as mock_exists:
- irt = getos.GetIrtBinPath(platform)
- mock_exists.assert_called_with(irt)
-
- def testGetLoaderPath(self):
- """checks that loader exists."""
- platform = getos.GetPlatform()
- with mock.patch('os.path.exists') as mock_exists:
- loader = getos.GetLoaderPath(platform)
- mock_exists.assert_called_with(loader)
-
def testGetNaClArch(self):
"""returns a valid architecture."""
platform = getos.GetPlatform()
« no previous file with comments | « native_client_sdk/src/tools/nacl_llvm.mk ('k') | native_client_sdk/src/tools/tests/nacl_config_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698