Issue 118553007: [NaCl SDK] Use nacl_config.py in common.mk build system.

Issue 118553007: [NaCl SDK] Use nacl_config.py in common.mk build system. (Closed)

Created:
6 years, 11 months ago by binji

Modified:
6 years, 11 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Use nacl_config.py in common.mk build system. Also, remove GetLoaderPath, GetHelperPath, GetIrtBinPath from getos.py. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243629

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -110 lines)			Patch
M	native_client_sdk/src/tools/common.mk	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	native_client_sdk/src/tools/getos.py	View	3 chunks	+0 lines, -41 lines	0 comments	Download
M	native_client_sdk/src/tools/nacl_config.py	View	4 chunks	+12 lines, -1 line	0 comments	Download
M	native_client_sdk/src/tools/nacl_gcc.mk	View	1 chunk	+22 lines, -23 lines	0 comments	Download
M	native_client_sdk/src/tools/nacl_llvm.mk	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	native_client_sdk/src/tools/tests/getos_test.py	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	native_client_sdk/src/tools/tests/nacl_config_test.py	View	4 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/118553007/1

6 years, 11 months ago (2014-01-06 21:34:33 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43410

6 years, 11 months ago (2014-01-06 21:48:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/118553007/1

6 years, 11 months ago (2014-01-08 17:18:21 UTC) #5

Message was sent while issue was closed.

Change committed as 243629

Expand Messages | Collapse Messages