Chromium Code Reviews| Index: content/browser/frame_host/render_frame_host_manager.cc |
| diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc |
| index 81bbe51ed74eff65d5dd167aa091777a57b91b8f..c560f24c0d861ce7824aea42fbfcafeea9c12eb9 100644 |
| --- a/content/browser/frame_host/render_frame_host_manager.cc |
| +++ b/content/browser/frame_host/render_frame_host_manager.cc |
| @@ -352,20 +352,6 @@ void RenderFrameHostManager::DidDisownOpener(RenderViewHost* render_view_host) { |
| } |
| } |
| -void RenderFrameHostManager::RendererAbortedProvisionalLoad( |
| - RenderViewHost* render_view_host) { |
| - // We used to cancel the pending renderer here for cross-site downloads. |
| - // However, it's not safe to do that because the download logic repeatedly |
| - // looks for this WebContents based on a render view ID. Instead, we just |
| - // leave the pending renderer around until the next navigation event |
| - // (Navigate, DidNavigate, etc), which will clean it up properly. |
|
Charlie Reis
2014/01/06 18:13:35
While it makes sense to remove this method, I thin
nasko
2014/01/06 18:47:03
Done.
|
| - // TODO(creis): All of this will go away when we move the cross-site logic |
| - // to ResourceDispatcherHost, so that we intercept responses rather than |
| - // navigation events. (That's necessary to support onunload anyway.) Once |
| - // we've made that change, we won't create a pending renderer until we know |
| - // the response is not a download. |
|
Charlie Reis
2014/01/06 18:13:35
This is an ancient TODO from 2008, when I was loos
nasko
2014/01/06 18:47:03
Done.
|
| -} |
| - |
| void RenderFrameHostManager::RendererProcessClosing( |
| RenderProcessHost* render_process_host) { |
| // Remove any swapped out RVHs from this process, so that we don't try to |