Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 118553006: Move DidFailProvisionalLoad handling from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Huh? Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index aaecd1efa31db0d9604cf2d85601971809053480..b8b840b208fef67c795fcce7c7478b5e7d49f7ca 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -17,6 +17,7 @@
#include "content/browser/frame_host/navigator.h"
#include "content/browser/site_instance_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/frame_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/notification_registrar.h"
@@ -954,7 +955,7 @@ TEST_F(NavigationControllerTest, LoadURL_AbortDoesntCancelPending) {
// It may abort before committing, if it's a download or due to a stop or
// a new navigation from the user.
- ViewHostMsg_DidFailProvisionalLoadWithError_Params params;
+ FrameHostMsg_DidFailProvisionalLoadWithError_Params params;
params.frame_id = 1;
params.is_main_frame = true;
params.error_code = net::ERR_ABORTED;
@@ -962,7 +963,7 @@ TEST_F(NavigationControllerTest, LoadURL_AbortDoesntCancelPending) {
params.url = kNewURL;
params.showing_repost_interstitial = false;
test_rvh()->OnMessageReceived(
- ViewHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
+ FrameHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
Charlie Reis 2014/01/06 18:13:35 nit: This had the wrong indent before, so we shoul
nasko 2014/01/06 18:47:03 Done.
params));
// This should not clear the pending entry or notify of a navigation state
@@ -1032,7 +1033,7 @@ TEST_F(NavigationControllerTest, LoadURL_RedirectAbortDoesntShowPendingURL) {
// It may abort before committing, if it's a download or due to a stop or
// a new navigation from the user.
- ViewHostMsg_DidFailProvisionalLoadWithError_Params params;
+ FrameHostMsg_DidFailProvisionalLoadWithError_Params params;
params.frame_id = 1;
params.is_main_frame = true;
params.error_code = net::ERR_ABORTED;
@@ -1040,7 +1041,7 @@ TEST_F(NavigationControllerTest, LoadURL_RedirectAbortDoesntShowPendingURL) {
params.url = kRedirectURL;
params.showing_repost_interstitial = false;
test_rvh()->OnMessageReceived(
- ViewHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
+ FrameHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
params));
// Because the pending entry is renderer initiated and not visible, we
@@ -2412,7 +2413,7 @@ TEST_F(NavigationControllerTest, RestoreNavigateAfterFailure) {
// which causes the pending entry to be cleared.
TestRenderViewHost* rvh =
static_cast<TestRenderViewHost*>(our_contents->GetRenderViewHost());
- ViewHostMsg_DidFailProvisionalLoadWithError_Params fail_load_params;
+ FrameHostMsg_DidFailProvisionalLoadWithError_Params fail_load_params;
fail_load_params.frame_id = 1;
fail_load_params.is_main_frame = true;
fail_load_params.error_code = net::ERR_ABORTED;
@@ -2420,7 +2421,7 @@ TEST_F(NavigationControllerTest, RestoreNavigateAfterFailure) {
fail_load_params.url = url;
fail_load_params.showing_repost_interstitial = false;
rvh->OnMessageReceived(
- ViewHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
+ FrameHostMsg_DidFailProvisionalLoadWithError(0, // routing_id
fail_load_params));
// Now the pending restored entry commits.
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.h » ('j') | content/browser/frame_host/navigator_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698