Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 118553004: aura: Add an EasyResizeWindowTargeter. (Closed)

Created:
6 years, 11 months ago by sadrul
Modified:
6 years, 11 months ago
CC:
chromium-reviews, kalyank, ben+aura_chromium.org, ben+ash_chromium.org, tdanderson
Visibility:
Public.

Description

aura: Add an EasyResizeWindowTargeter. Add EasyResizeWindowTargeter to allow easily resizing windows with mouse/touch with the new event-dispatch code. This will eventually allow getting rid of Window::SetHitTestBoundsOverrideOuter() once the new event-dispatch code is used for all event types. This patch installs an EasyResizeWindowTargeter for the shelf and status-area widgets. Subsequent CLs will install such targeters for the toplevel windows too. Collateral change includes adding some dependencies on wm_public (in DEPS and gyp). BUG=318879 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243177

Patch Set 1 #

Patch Set 2 : deps #

Patch Set 3 : . #

Patch Set 4 : tests #

Patch Set 5 : tests #

Patch Set 6 : tweak #

Patch Set 7 : tot-merge-r243131 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -15 lines) Patch
M ash/ash.gyp View 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 3 3 chunks +77 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 3 2 chunks +116 lines, -1 line 0 comments Download
M ui/aura/window_targeter.h View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download
M ui/aura/window_targeter.cc View 2 chunks +25 lines, -12 lines 0 comments Download
A + ui/wm/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A ui/wm/core/easy_resize_window_targeter.cc View 1 2 3 4 5 1 chunk +48 lines, -0 lines 0 comments Download
A ui/wm/public/easy_resize_window_targeter.h View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 11 months ago (2014-01-04 08:59:17 UTC) #1
Ben Goodger (Google)
Cool! lgtm
6 years, 11 months ago (2014-01-06 17:33:43 UTC) #2
sadrul
6 years, 11 months ago (2014-01-06 22:00:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #7 manually as r243177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698