test/cctest/test-api.cc - Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge

Patch Set: Some test improvements. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index 38c8ac78bc52eb577b675d1877b6c46445d81327..67a81edd8a243f29962fa3dba10cff152a69ff63 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -2787,7 +2787,7 @@ THREADED_TEST(SymbolProperties) {

CHECK(sym_obj->IsSymbolObject());

CHECK(!sym2->IsSymbolObject());

CHECK(!obj->IsSymbolObject());

- CHECK(sym_obj->Equals(sym2));

+ CHECK(!sym_obj->Equals(sym2));

CHECK(!sym_obj->StrictEquals(sym2));

CHECK(v8::SymbolObject::Cast(*sym_obj)->Equals(sym_obj));

CHECK(v8::SymbolObject::Cast(*sym_obj)->ValueOf()->Equals(sym2));

« no previous file with comments | « src/symbol.js ('k') | test/mjsunit/harmony/private.js » ('j') | no next file with comments »