Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: src/ic.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Remove uninteresting equality test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/messages.js » ('j') | src/symbol.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index c79ea2c7cf09e9b194a27b7c18e36f9164588884..57479ba5c39fc4e9db3efaca32dbd8468e6b090b 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -928,6 +928,8 @@ Handle<Code> LoadIC::CompileHandler(LookupResult* lookup,
if (!getter->IsJSFunction()) break;
if (holder->IsGlobalObject()) break;
if (!holder->HasFastProperties()) break;
+ // Symbol builtins expect the value to be boxed.
+ if (object->IsSymbol()) break;
Handle<JSFunction> function = Handle<JSFunction>::cast(getter);
if (!object->IsJSObject() &&
!function->IsBuiltin() &&
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/messages.js » ('j') | src/symbol.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698