Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: src/stub-cache.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Fix fundamental issues surrounding Symbol values vs (wrapper) objects Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/stub-cache.cc
diff --git a/src/stub-cache.cc b/src/stub-cache.cc
index dc2c3406a6aead526238893d801b8abc8efe565b..6b6cc5df05cc9e45c9f6bdc868c6f59621d8579f 100644
--- a/src/stub-cache.cc
+++ b/src/stub-cache.cc
@@ -281,6 +281,11 @@ Handle<Code> StubCache::ComputeCallConstant(int argc,
// requires boxing.
return Handle<Code>::null();
}
+ if (check == SYMBOL_CHECK) {
+ // Boxing always required for Symbol value receivers,
+ // as even Symbol builtins expect them to be boxed.
+ return Handle<Code>::null();
+ }
Code::Flags flags = Code::ComputeMonomorphicFlags(
kind, extra_state, cache_holder, Code::FAST, argc);

Powered by Google App Engine
This is Rietveld 408576698