src/objects.cc - Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge

Patch Set: Fix fundamental issues surrounding Symbol values vs (wrapper) objects Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index cf21e802ebc14b32afd64beb0a891939bc213ea5..16754ace205d04c68b42085991dd3ef26bf904f7 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -81,6 +81,8 @@ MaybeObject* Object::ToObject(Context* native_context) {

return CreateJSValue(native_context->boolean_function(), this);

} else if (IsString()) {

return CreateJSValue(native_context->string_function(), this);

+ } else if (IsSymbol()) {

+ return CreateJSValue(native_context->symbol_function(), this);

}

ASSERT(IsJSObject());

return this;