Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/ic.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Remove uninteresting equality test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 Handle<ExecutableAccessorInfo>::cast(callback); 921 Handle<ExecutableAccessorInfo>::cast(callback);
922 if (v8::ToCData<Address>(info->getter()) == 0) break; 922 if (v8::ToCData<Address>(info->getter()) == 0) break;
923 if (!info->IsCompatibleReceiver(*object)) break; 923 if (!info->IsCompatibleReceiver(*object)) break;
924 return compiler.CompileLoadCallback(type, holder, name, info); 924 return compiler.CompileLoadCallback(type, holder, name, info);
925 } else if (callback->IsAccessorPair()) { 925 } else if (callback->IsAccessorPair()) {
926 Handle<Object> getter(Handle<AccessorPair>::cast(callback)->getter(), 926 Handle<Object> getter(Handle<AccessorPair>::cast(callback)->getter(),
927 isolate()); 927 isolate());
928 if (!getter->IsJSFunction()) break; 928 if (!getter->IsJSFunction()) break;
929 if (holder->IsGlobalObject()) break; 929 if (holder->IsGlobalObject()) break;
930 if (!holder->HasFastProperties()) break; 930 if (!holder->HasFastProperties()) break;
931 // Symbol builtins expect the value to be boxed.
932 if (object->IsSymbol()) break;
931 Handle<JSFunction> function = Handle<JSFunction>::cast(getter); 933 Handle<JSFunction> function = Handle<JSFunction>::cast(getter);
932 if (!object->IsJSObject() && 934 if (!object->IsJSObject() &&
933 !function->IsBuiltin() && 935 !function->IsBuiltin() &&
934 function->shared()->is_classic_mode()) { 936 function->shared()->is_classic_mode()) {
935 // Calling non-strict non-builtins with a value as the receiver 937 // Calling non-strict non-builtins with a value as the receiver
936 // requires boxing. 938 // requires boxing.
937 break; 939 break;
938 } 940 }
939 CallOptimization call_optimization(function); 941 CallOptimization call_optimization(function);
940 if (call_optimization.is_simple_api_call() && 942 if (call_optimization.is_simple_api_call() &&
(...skipping 1864 matching lines...) Expand 10 before | Expand all | Expand 10 after
2805 #undef ADDR 2807 #undef ADDR
2806 }; 2808 };
2807 2809
2808 2810
2809 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2811 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2810 return IC_utilities[id]; 2812 return IC_utilities[id];
2811 } 2813 }
2812 2814
2813 2815
2814 } } // namespace v8::internal 2816 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/messages.js » ('j') | src/symbol.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698