Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/messages.js

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: Fix fundamental issues surrounding Symbol values vs (wrapper) objects Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 strict_function: ["In strict mode code, functions can only be de clared at top level or immediately within another function." ], 174 strict_function: ["In strict mode code, functions can only be de clared at top level or immediately within another function." ],
175 strict_read_only_property: ["Cannot assign to read only property '", "%0", "' of ", "%1"], 175 strict_read_only_property: ["Cannot assign to read only property '", "%0", "' of ", "%1"],
176 strict_cannot_assign: ["Cannot assign to read only '", "%0", "' in st rict mode"], 176 strict_cannot_assign: ["Cannot assign to read only '", "%0", "' in st rict mode"],
177 strict_poison_pill: ["'caller', 'callee', and 'arguments' propertie s may not be accessed on strict mode functions or the arguments objects for call s to them"], 177 strict_poison_pill: ["'caller', 'callee', and 'arguments' propertie s may not be accessed on strict mode functions or the arguments objects for call s to them"],
178 strict_caller: ["Illegal access to a strict mode caller functi on."], 178 strict_caller: ["Illegal access to a strict mode caller functi on."],
179 unprotected_let: ["Illegal let declaration in unprotected statem ent context."], 179 unprotected_let: ["Illegal let declaration in unprotected statem ent context."],
180 unprotected_const: ["Illegal const declaration in unprotected stat ement context."], 180 unprotected_const: ["Illegal const declaration in unprotected stat ement context."],
181 cant_prevent_ext_external_array_elements: ["Cannot prevent extension of an obj ect with external array elements"], 181 cant_prevent_ext_external_array_elements: ["Cannot prevent extension of an obj ect with external array elements"],
182 redef_external_array_element: ["Cannot redefine a property of an object with external array elements"], 182 redef_external_array_element: ["Cannot redefine a property of an object with external array elements"],
183 harmony_const_assign: ["Assignment to constant variable."], 183 harmony_const_assign: ["Assignment to constant variable."],
184 symbol_to_string: ["Conversion from symbol to string"], 184 symbol_to_string: ["Cannot convert Symbol values to strings"],
arv (Not doing code reviews) 2014/02/01 01:33:10 "value to string" maybe?
185 symbol_to_value: ["Cannot call valueOf() on a Symbol value."],
186 symbol_to_primitive: ["Cannot convert Symbol wrapper objects to prim itive values"],
arv (Not doing code reviews) 2014/02/01 01:33:10 same?
185 invalid_module_path: ["Module does not export '", "%0", "', or expor t is not itself a module"], 187 invalid_module_path: ["Module does not export '", "%0", "', or expor t is not itself a module"],
186 module_type_error: ["Module '", "%0", "' used improperly"], 188 module_type_error: ["Module '", "%0", "' used improperly"],
187 module_export_undefined: ["Export '", "%0", "' is not defined in module" ] 189 module_export_undefined: ["Export '", "%0", "' is not defined in module" ]
188 }; 190 };
189 191
190 192
191 function FormatString(format, args) { 193 function FormatString(format, args) {
192 var result = ""; 194 var result = "";
193 var arg_num = 0; 195 var arg_num = 0;
194 for (var i = 0; i < format.length; i++) { 196 for (var i = 0; i < format.length; i++) {
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 %GetAndClearOverflowedStackTrace(this); 1357 %GetAndClearOverflowedStackTrace(this);
1356 }; 1358 };
1357 1359
1358 %DefineOrRedefineAccessorProperty( 1360 %DefineOrRedefineAccessorProperty(
1359 boilerplate, 'stack', getter, setter, DONT_ENUM); 1361 boilerplate, 'stack', getter, setter, DONT_ENUM);
1360 1362
1361 return boilerplate; 1363 return boilerplate;
1362 } 1364 }
1363 1365
1364 var kStackOverflowBoilerplate = SetUpStackOverflowBoilerplate(); 1366 var kStackOverflowBoilerplate = SetUpStackOverflowBoilerplate();
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/objects.cc » ('j') | test/mjsunit/harmony/symbols.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698