Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11855016: Avoid trying to inline identical, and avoid shadowing identical. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 17141)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -3435,7 +3435,10 @@
}
compiler.ensure(!element.isGenerativeConstructor());
if (element.isFunction()) {
- if (tryInlineMethod(element, selector, node.arguments)) {
+ bool isIdenticalFunction = element == compiler.identicalFunction;
+
+ if (!isIdenticalFunction
+ && tryInlineMethod(element, selector, node.arguments)) {
return;
}
@@ -3452,7 +3455,7 @@
return;
}
- if (identical(element, compiler.identicalFunction)) {
+ if (isIdenticalFunction) {
pushWithPosition(new HIdentity(target, inputs[1], inputs[2]), node);
return;
}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698