Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: public/platform/WebServiceWorkerProvider.h

Issue 1185483003: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove ifdef Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/platform/WebServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebServiceWorkerProvider.h
diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h
index ca60a58314672b1972dd2b33fd46b46b5b74118d..1ba98964006fed35552dc0ee23318ab80154742d 100644
--- a/public/platform/WebServiceWorkerProvider.h
+++ b/public/platform/WebServiceWorkerProvider.h
@@ -54,14 +54,15 @@ public:
// The WebServiceWorkerRegistration and WebServiceWorkerError ownership are
// passed to the WebServiceWorkerRegistrationCallbacks implementation.
typedef WebCallbacks<WebServiceWorkerRegistration, WebServiceWorkerError> WebServiceWorkerRegistrationCallbacks;
- typedef WebCallbacks<bool, WebServiceWorkerError> WebServiceWorkerUnregistrationCallbacks;
typedef WebCallbacks<WebServiceWorkerRegistration, WebServiceWorkerError> WebServiceWorkerGetRegistrationCallbacks;
typedef WebCallbacks<WebVector<WebServiceWorkerRegistration*>, WebServiceWorkerError> WebServiceWorkerGetRegistrationsCallbacks;
typedef WebCallbacks<WebServiceWorkerRegistration, void> WebServiceWorkerGetRegistrationForReadyCallbacks;
virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }
- // Unregisters the ServiceWorker for a given scope.
+ // TODO(nhiroki): Remove after http://crbug.com/500404 is fixed.
+#define CRBUG_500404
+ typedef WebCallbacks<bool, WebServiceWorkerError> WebServiceWorkerUnregistrationCallbacks;
virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerUnregistrationCallbacks*) { }
virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { }
« no previous file with comments | « no previous file | public/platform/WebServiceWorkerRegistration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698