Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1185473002: Move sky_home.* from domokit.github.io into our repo (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move sky_home.* from domokit.github.io into our repo This makes it easier to keep sky_home links working. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2000ccd3832d041289b74f3f7d6c5de6c55ff471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M mojo/tools/deploy_domokit_site.py View 2 chunks +14 lines, -0 lines 0 comments Download
A sky/sky_home View 1 chunk +10 lines, -0 lines 0 comments Download
A sky/sky_home.dart View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
Should we switch sky_home to the new world and then we could just have one ...
5 years, 6 months ago (2015-06-11 21:15:12 UTC) #1
abarth-chromium
LGTM
5 years, 6 months ago (2015-06-11 21:15:23 UTC) #2
eseidel
5 years, 6 months ago (2015-06-11 21:22:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2000ccd3832d041289b74f3f7d6c5de6c55ff471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698