Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1185453011: Revert of Update V8 DEPS. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
v8-autoroll
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/1192033002/) Reason for revert: [Sheriff] gyp still contains an offending patch Original issue's description: > Update V8 DEPS. > > Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 > > Rolling v8/tools/clang to d2b4eddd701ff0265124147bcb0a65f32273f06b > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/a940eb8a7cba6596ea25819c0112c3ca053074ed > Cr-Commit-Position: refs/heads/master@{#29097} TBR=v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/91d869a343da9351ab57540fa1e1fcdf32e3f8e6 Cr-Commit-Position: refs/heads/master@{#29099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Update V8 DEPS.
5 years, 6 months ago (2015-06-18 06:24:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185453011/1
5 years, 6 months ago (2015-06-18 06:24:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 06:24:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 06:24:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91d869a343da9351ab57540fa1e1fcdf32e3f8e6
Cr-Commit-Position: refs/heads/master@{#29099}

Powered by Google App Engine
This is Rietveld 408576698