Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1185453003: fix deserialization after FirstDirection change to paths (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix deserialization after FirstDirection change to paths BUG=skia: Committed: https://skia.googlesource.com/skia/+/8f086023bf615b2661b82bcf59cdedde78ad7374

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M include/core/SkPath.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 2 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
5 years, 6 months ago (2015-06-11 20:51:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185453003/1
5 years, 6 months ago (2015-06-11 20:51:32 UTC) #4
reed1
5 years, 6 months ago (2015-06-11 20:52:02 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 20:57:13 UTC) #8
egdaniel
lgtm with minor question https://codereview.chromium.org/1185453003/diff/20001/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/1185453003/diff/20001/src/core/SkPath.cpp#newcode1887 src/core/SkPath.cpp:1887: fFirstDirection = (packed >> kDirection_SerializationShift) ...
5 years, 6 months ago (2015-06-11 21:12:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185453003/40001
5 years, 6 months ago (2015-06-11 21:16:41 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:22:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8f086023bf615b2661b82bcf59cdedde78ad7374

Powered by Google App Engine
This is Rietveld 408576698