extensions: Use V8 Maybe APIs in ModuleSystem

extensions/renderer/module_system_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/module_system_test.h"
 
 #include <map>
 #include <string>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"
 #include "extensions/common/extension_paths.h"
 #include "extensions/renderer/logging_native_handler.h"
 #include "extensions/renderer/object_backed_native_handler.h"
 #include "extensions/renderer/safe_builtins.h"
 #include "extensions/renderer/utils_native_handler.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace extensions {
 namespace {
 
 class FailsOnException : public ModuleSystem::ExceptionHandler {
  public:
+  FailsOnException() : ModuleSystem::ExceptionHandler(nullptr) {}
   void HandleUncaughtException(const v8::TryCatch& try_catch) override {
     FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch);
   }
 };
 
 class V8ExtensionConfigurator {
  public:
   V8ExtensionConfigurator()
       : safe_builtins_(SafeBuiltins::CreateV8Extension()),
         names_(1, safe_builtins_->name()),
@@ skipping 82 matching lines @@
 };
 
 ModuleSystemTestEnvironment::ModuleSystemTestEnvironment(v8::Isolate* isolate)
     : isolate_(isolate),
       context_holder_(new gin::ContextHolder(isolate_)),
       handle_scope_(isolate_),
       source_map_(new StringSourceMap()) {
   context_holder_->SetContext(v8::Context::New(
       isolate, g_v8_extension_configurator.Get().GetConfiguration()));
   context_.reset(new ScriptContext(context_holder_->context(),
-                                   NULL,  // WebFrame
-                                   NULL,  // Extension
+                                   nullptr,  // WebFrame
+                                   nullptr,  // Extension
                                    Feature::BLESSED_EXTENSION_CONTEXT,
-                                   NULL,  // Effective Extension
+                                   nullptr,  // Effective Extension
                                    Feature::BLESSED_EXTENSION_CONTEXT));
   context_->v8_context()->Enter();
   assert_natives_ = new AssertNatives(context_.get());
 
   {
     scoped_ptr<ModuleSystem> module_system(
         new ModuleSystem(context_.get(), source_map_.get()));
     context_->set_module_system(module_system.Pass());
   }
   ModuleSystem* module_system = context_->module_system();
@@ skipping 101 matching lines @@
 
 void ModuleSystemTest::ExpectNoAssertionsMade() {
   should_assertions_be_made_ = false;
 }
 
 void ModuleSystemTest::RunResolvedPromises() {
   isolate_->RunMicrotasks();
 }
 
 }  // namespace extensions