Issue 118543002: Move sticky keys files to their own directory and rename to StickyKeysController.

Issue 118543002: Move sticky keys files to their own directory and rename to StickyKeysController. (Closed)

Created:
7 years ago by Tim Song

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move sticky keys files to their own directory and rename to StickyKeysController. There will be new files added for the sticky keys UI in the future, and this refactor improves organization for sticky keys code and is more inline with how the other accessibility features are organized. TEST=StickyKeysTests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242036

Patch Set 1 #

Patch Set 2 : update ash.gyp #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1607 lines)			Patch
M	ash/ash.gyp	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/shell.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/shell.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A	ash/sticky_keys/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	ash/sticky_keys/sticky_keys_controller.h	View		5 chunks	+15 lines, -15 lines	0 comments	Download
A +	ash/sticky_keys/sticky_keys_controller.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download
A +	ash/sticky_keys/sticky_keys_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
D	ash/wm/sticky_keys.h	View		1 chunk	+0 lines, -240 lines	0 comments	Download
D	ash/wm/sticky_keys.cc	View		1 chunk	+0 lines, -445 lines	0 comments	Download
D	ash/wm/sticky_keys_unittest.cc	View		1 chunk	+0 lines, -877 lines	0 comments	Download
M	chrome/browser/chromeos/accessibility/accessibility_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/118543002/1

7 years ago (2013-12-19 00:22:19 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=238136

7 years ago (2013-12-19 02:04:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/118543002/20001

7 years ago (2013-12-20 02:25:04 UTC) #5

Message was sent while issue was closed.

Change committed as 242036

Expand Messages | Collapse Messages