Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1185423004: Avoid resetting rule features when removing style-less shadow. (Closed)

Created:
5 years, 6 months ago by rune
Modified:
5 years, 6 months ago
Reviewers:
tkent, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid resetting rule features when removing style-less shadow. We reset the global rule features when removing a shadow root from the tree. There is no reason to do that if the scope does not contain style, so we'll skip the reset when there is no ScopedStyleResolver. In particular, this can be the case for UA shadow roots. For the case where the scope contains style, this will be fixed by componentized style resolving. What occurs in issue 499349 is: 1. Remove a form child which is an input with a UA shadow root. 2. Removing the root causes rule features to be reset globally. 3. Removing an input child of a form requires a validity check. 4. The validity check schedules an invalidation for :valid etc. 5. Scheduling invalidation sets require an up-to-date rule feature set which includes invalidation sets, so the rule features are collected. 1-5 is repeated for each removed input. The global feature collection in step 5 is the expensive part here. R=tkent@chromium.org,esprehn@chromium.org BUG=499349 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
5 years, 6 months ago (2015-06-16 21:08:03 UTC) #1
esprehn
lgtm
5 years, 6 months ago (2015-06-16 21:21:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185423004/1
5 years, 6 months ago (2015-06-16 21:22:04 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 23:10:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197204

Powered by Google App Engine
This is Rietveld 408576698