Add a Paint::toString() method to describe our Paint objects.

sky/tests/resources/display_list.dart

 
 import 'dart:async';
 import 'dart:sky' as sky;
 import "dart:sky.internals" as internals;
 
 import 'package:sky/widgets/basic.dart';
 import 'package:sky/rendering/box.dart';
 import 'package:sky/rendering/object.dart';
 
 typedef void Logger (String s);
 
 class TestDisplayList extends RenderObjectDisplayList {
   TestDisplayList(double width, double height, this.logger, { this.indent: '' }) :
     this.width = width,
     this.height = height,
     super(width, height) {
     log("TestDisplayList() constructor: $width x $height");
   }
 
   final String indent;
   final double width;
   final double height;
 
   Logger logger;
   void log(String s) {
     logger("${indent} ${s}");
   }
 
-  String explainPaint(Paint paint) {
-    assert(paint.toString() == "Instance of 'Paint'"); // if this assertion fails, remove all calls to explainPaint with just inlining $paint
-    return "Paint(${paint.color})";
-  }
-
   void save() {
     log("save");
   }
 
   void saveLayer(Rect bounds, Paint paint) {
-    log("saveLayer($bounds, ${explainPaint(paint)})");
+    log("saveLayer($bounds, $paint)");
   }
 
   void restore() {
     log("restore");
   }
 
   void translate(double dx, double dy) {
     log("translate($dx, $dy)");
   }
 
@@ skipping 19 matching lines @@
 
   void clipRRect(sky.RRect rrect) {
     log("clipRRect()");
   }
 
   void clipPath(Path path) {
     log("clipPath($path)");
   }
 
   void drawLine(double x0, double y0, double x1, double y1, Paint paint) {
-    log("drawLine($x0, $y0, $x1, $y1, ${explainPaint(paint)})");
+    log("drawLine($x0, $y0, $x1, $y1, $paint)");
   }
 
   void drawPicture(sky.Picture picture) {
     log("drawPicture($picture)");
   }
 
   void drawPaint(Paint paint) {
-    log("drawPaint(${explainPaint(paint)})");
+    log("drawPaint($paint)");
   }
 
   void drawRect(Rect rect, Paint paint) {
-    log("drawRect($rect, ${explainPaint(paint)})");
+    log("drawRect($rect, $paint)");
   }
 
   void drawRRect(sky.RRect rrect, Paint paint) {
-    log("drawRRect($rrect, ${explainPaint(paint)})");
+    log("drawRRect($rrect, $paint)");
   }
 
   void drawOval(Rect rect, Paint paint) {
-    log("drawOval($rect, ${explainPaint(paint)})");
+    log("drawOval($rect, $paint)");
   }
 
   void drawCircle(double x, double y, double radius, Paint paint) {
-    log("drawCircle($x, $y, $radius, ${explainPaint(paint)})");
+    log("drawCircle($x, $y, $radius, $paint)");
   }
 
   void drawPath(Path path, Paint paint) {
-    log("drawPath($path, ${explainPaint(paint)})");
+    log("drawPath($path, $paint)");
   }
 
   void drawImage(sky.Image image, double x, double y, Paint paint) {
-    log("drawImage($image, $x, $y, ${explainPaint(paint)})");
+    log("drawImage($image, $x, $y, $paint)");
   }
 
   void paintChild(RenderObject child, Point position) {
     log("paintChild ${child.runtimeType} at $position");
     child.paint(new TestDisplayList(width, height, logger, indent: "$indent  |"));
   }
 }
 
 class TestRenderView extends RenderView {
 
@@ skipping 56 matching lines @@
 
   Future test(Function builder) {
     runApp(new TestApp(builder: builder), renderViewOverride: renderView);
     return renderView.checkFrame();
   }
 
   void endTest() {
     renderView.endTest();
   }
 }