Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1185413002: Key refactor, part 1: remove the dependence on the runtimeType in keys, otherwise they'll get overl… (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Key refactor, part 1: remove the dependence on the runtimeType in keys, otherwise they'll get overly long very quickly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7dcd3a9bb116536960884615219f58f3b4e96666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M sky/sdk/lib/widgets/widget.dart View 11 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-16 18:30:03 UTC) #2
Hixie
5 years, 6 months ago (2015-06-16 18:31:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7dcd3a9bb116536960884615219f58f3b4e96666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698