Issue 11854009: Change spanFromNode to spanFromSpannable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11854009: Change spanFromNode to spanFromSpannable. (Closed)

Created:
7 years, 11 months ago by Johnni Winther

Modified:
7 years, 11 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change spanFromNode to spanFromSpannable. Committed: https://code.google.com/p/dart/source/detail?r=16964

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -25 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	10 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

7 years, 11 months ago (2013-01-11 11:34:34 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11854009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart (right):

https://codereview.chromium.org/11854009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart:19:
SourceSpan spanFromSpannable(Node node, [Uri uri]);
Node should (of course) have been Spannable. I'll change it in a later CL.

Expand Messages | Collapse Messages