Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1185383002: [SVG] Re-enable experimental PathOpsSVGClipping support (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
fs, caryclark
CC:
f(malita), blink-reviews, blink-reviews-rendering, Rik, danakj, dshwang, krit, eae+blinkwatch, fs, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, reed1, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SVG] Re-enable experimental PathOpsSVGClipping support All known PathOps issues have been addressed, re-enabling. Also refactored to use an SkOpBuilder for more effcient path unioning. BUG=263911 R=caryclark@google.com,fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197202

Patch Set 1 #

Patch Set 2 : expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 3 chunks +22 lines, -8 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Path.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/Path.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
f(malita)
13 trivial rebaselines: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/66857/layout-test-results/results.html I've also verified this against previous clipping perf regressions: http://crbug.com/423749 http://crbug.com/434405
4 years, 10 months ago (2015-06-16 17:00:22 UTC) #1
fs
LGTM - second(?) times the charm!
4 years, 10 months ago (2015-06-16 19:04:51 UTC) #2
caryclark
lgtm
4 years, 10 months ago (2015-06-16 19:07:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185383002/20001
4 years, 10 months ago (2015-06-16 19:19:29 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 21:46:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197202

Powered by Google App Engine
This is Rietveld 408576698