Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1185373004: Only walk the hidden prototype chain for private nonexistent symbols (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only walk the hidden prototype chain for private nonexistent symbols BUG=chromium:479528 LOG=n Committed: https://crrev.com/bb1b54a776856280598bc5a0aa17ce2256996515 Cr-Commit-Position: refs/heads/master@{#29075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M src/ic/handler-compiler.cc View 2 chunks +14 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-479528.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-17 09:34:15 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-17 09:38:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185373004/1
5 years, 6 months ago (2015-06-17 09:47:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 10:20:47 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 10:20:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb1b54a776856280598bc5a0aa17ce2256996515
Cr-Commit-Position: refs/heads/master@{#29075}

Powered by Google App Engine
This is Rietveld 408576698