Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 1185373002: DevTools: fix DOMBreakpoints checkboxes in elements panel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 * @param {!DOMDebuggerAgent.DOMBreakpointType} type 216 * @param {!DOMDebuggerAgent.DOMBreakpointType} type
217 * @param {boolean} enabled 217 * @param {boolean} enabled
218 */ 218 */
219 _createBreakpointElement: function(node, type, enabled) 219 _createBreakpointElement: function(node, type, enabled)
220 { 220 {
221 var element = createElement("li"); 221 var element = createElement("li");
222 element._node = node; 222 element._node = node;
223 element._type = type; 223 element._type = type;
224 element.addEventListener("contextmenu", this._contextMenu.bind(this, nod e, type), true); 224 element.addEventListener("contextmenu", this._contextMenu.bind(this, nod e, type), true);
225 225
226 var checkboxElement = createCheckboxLabel("", enabled); 226 var checkboxLabel = createCheckboxLabel("", enabled);
227 checkboxElement.addEventListener("click", this._checkboxClicked.bind(thi s, node, type), false); 227 checkboxLabel.addEventListener("click", this._checkboxClicked.bind(this, node, type), false);
228 element._checkboxElement = checkboxElement; 228 element._checkboxElement = checkboxLabel.checkboxElement;
229 element.appendChild(checkboxElement); 229 element.appendChild(checkboxLabel);
230 230
231 var labelElement = createElement("span"); 231 var labelElement = createElement("span");
232 element.appendChild(labelElement); 232 element.appendChild(labelElement);
233 233
234 var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReferen ce(node); 234 var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReferen ce(node);
235 linkifiedNode.classList.add("monospace"); 235 linkifiedNode.classList.add("monospace");
236 labelElement.appendChild(linkifiedNode); 236 labelElement.appendChild(linkifiedNode);
237 237
238 var description = createElement("div"); 238 var description = createElement("div");
239 description.className = "source-text"; 239 description.className = "source-text";
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 this._wrappedPane.show(this.element); 456 this._wrappedPane.show(this.element);
457 }, 457 },
458 458
459 __proto__: WebInspector.SidebarPane.prototype 459 __proto__: WebInspector.SidebarPane.prototype
460 } 460 }
461 461
462 /** 462 /**
463 * @type {!WebInspector.DOMBreakpointsSidebarPane} 463 * @type {!WebInspector.DOMBreakpointsSidebarPane}
464 */ 464 */
465 WebInspector.domBreakpointsSidebarPane; 465 WebInspector.domBreakpointsSidebarPane;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698