Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(116)

Issue 1185373002: DevTools: fix DOMBreakpoints checkboxes in elements panel (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix DOMBreakpoints checkboxes in elements panel Due to refactoring in r196782, a checkbox object does not refer a checkbox. BUG=500815 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
ptal
4 years, 10 months ago (2015-06-16 16:05:53 UTC) #1
pfeldman
lgtm. thank you.
4 years, 10 months ago (2015-06-16 18:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185373002/1
4 years, 10 months ago (2015-06-16 18:34:19 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 20:40:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197191

Powered by Google App Engine
This is Rietveld 408576698