Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1185363002: webui: Do not set 'toolkit' property for webui. (Closed)

Created:
5 years, 6 months ago by sadrul
Modified:
5 years, 6 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webui: Do not set 'toolkit' property for webui. The 'toolkit' property is no longer used by webui pages. So do not set it anymore for views. Also, remove associated functions for detecting gtk. BUG=500004 Committed: https://crrev.com/37c71fc16baac96ffc19e39e4a112cdae4e295da Cr-Commit-Position: refs/heads/master@{#334888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M chrome/common/extensions/docs/examples/api/fontSettings/js/cr.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js View 3 chunks +0 lines, -19 lines 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/webui/resources/js/cr.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
5 years, 6 months ago (2015-06-16 14:28:15 UTC) #2
sadrul
+jhawkins@ instead since estade@ is OOO
5 years, 6 months ago (2015-06-16 19:55:59 UTC) #4
James Hawkins
lgtm
5 years, 6 months ago (2015-06-17 17:58:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185363002/1
5 years, 6 months ago (2015-06-17 19:12:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 19:18:18 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 19:19:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37c71fc16baac96ffc19e39e4a112cdae4e295da
Cr-Commit-Position: refs/heads/master@{#334888}

Powered by Google App Engine
This is Rietveld 408576698