Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: Source/modules/accessibility/AXLayoutObject.h

Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved layout tests to another CL. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXInlineTextBox.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXLayoutObject.h
diff --git a/Source/modules/accessibility/AXLayoutObject.h b/Source/modules/accessibility/AXLayoutObject.h
index b266463b8f86d0229ca5994a5175542c88eb1562..69a0b3dae5570af6dd338d542517eba43fb0be98 100644
--- a/Source/modules/accessibility/AXLayoutObject.h
+++ b/Source/modules/accessibility/AXLayoutObject.h
@@ -43,7 +43,6 @@ class FrameView;
class HTMLAreaElement;
class IntPoint;
class Node;
-class VisibleSelection;
class Widget;
class MODULES_EXPORT AXLayoutObject : public AXNodeObject {
@@ -151,6 +150,12 @@ protected:
// Accessibility Text - (To be deprecated).
String deprecatedHelpText() const override;
+ // Methods that retrieve or manipulate the current selection.
+
+ AXRange selection() const override;
+ AXRange selectionUnderObject() const override;
+ void setSelection(const AXRange&) override;
+
// Location and click point in frame-relative coordinates.
void markCachedElementRectDirty() const override;
IntPoint clickPoint() override;
@@ -183,11 +188,6 @@ protected:
Element* anchorElement() const override;
Widget* widgetForAttachmentView() const override;
- // Selected text.
- PlainTextRange selectedTextRange() const override;
-
- // Modify or take an action on an object.
- void setSelectedTextRange(const PlainTextRange&) override;
void setValue(const String&) override;
// Notifications that this object may have changed.
@@ -203,9 +203,9 @@ protected:
private:
AXObject* treeAncestorDisallowingChild() const;
void ariaListboxSelectedChildren(AccessibilityChildrenVector&);
- PlainTextRange visibleSelectionUnderObject() const;
bool nodeIsTextControl(const Node*) const;
bool isTabItemSelected() const;
+ bool isValidSelectionBound(const AXObject*) const;
AXObject* accessibilityImageMapHitTest(HTMLAreaElement*, const IntPoint&) const;
LayoutObject* layoutParentObject() const;
bool isSVGImage() const;
@@ -225,7 +225,7 @@ private:
void ariaSelectedRows(AccessibilityChildrenVector&);
bool elementAttributeValue(const QualifiedName&) const;
LayoutRect computeElementRect() const;
- VisibleSelection selection() const;
+ AXRange textControlSelection() const;
int indexForVisiblePosition(const VisiblePosition&) const;
};
« no previous file with comments | « Source/modules/accessibility/AXInlineTextBox.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698