Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: Source/modules/accessibility/AXLayoutObject.h

Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXLayoutObject.h
diff --git a/Source/modules/accessibility/AXLayoutObject.h b/Source/modules/accessibility/AXLayoutObject.h
index d9f6af988cf90d2254ad4561ed8bc5392b3d99b1..32d8a692ba726e7b3bc2e1d6f7b56743b4ece921 100644
--- a/Source/modules/accessibility/AXLayoutObject.h
+++ b/Source/modules/accessibility/AXLayoutObject.h
@@ -182,12 +182,11 @@ protected:
virtual FrameView* documentFrameView() const override;
virtual Element* anchorElement() const override;
virtual Widget* widgetForAttachmentView() const override;
-
- // Selected text.
- virtual PlainTextRange selectedTextRange() const override;
+ virtual AXSelection selection() const override;
dmazzoni 2015/06/16 17:24:03 These should all be in their own section with comm
+ virtual AXSelection selectionUnderObject() const override;
// Modify or take an action on an object.
- virtual void setSelectedTextRange(const PlainTextRange&) override;
+ virtual void setSelection(const AXSelection&) override;
virtual void setValue(const String&) override;
// Notifications that this object may have changed.
@@ -203,7 +202,6 @@ protected:
private:
AXObject* treeAncestorDisallowingChild() const;
void ariaListboxSelectedChildren(AccessibilityChildrenVector&);
- PlainTextRange visibleSelectionUnderObject() const;
bool nodeIsTextControl(const Node*) const;
bool isTabItemSelected() const;
AXObject* accessibilityImageMapHitTest(HTMLAreaElement*, const IntPoint&) const;
@@ -225,7 +223,8 @@ private:
void ariaSelectedRows(AccessibilityChildrenVector&);
bool elementAttributeValue(const QualifiedName&) const;
LayoutRect computeElementRect() const;
- VisibleSelection selection() const;
+ AXObject::AXSelection textControlSelection() const;
dmazzoni 2015/06/16 17:24:03 The AXObject:: qualifier shouldn't be needed here
+ VisibleSelection visibleSelection() const;
int indexForVisiblePosition(const VisiblePosition&) const;
};

Powered by Google App Engine
This is Rietveld 408576698