content/public/common/sandboxed_process_launcher_delegate.h - Issue 1185333003: Implement GetSandboxType() on all platforms and implement for all process types.

Unified Diff: content/public/common/sandboxed_process_launcher_delegate.h

Issue 1185333003: Implement GetSandboxType() on all platforms and implement for all process types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/content_browser_client.h ('K') | « content/public/common/sandbox_type_mac.h ('k') | content/public/common/sandboxed_process_launcher_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/sandboxed_process_launcher_delegate.h

diff --git a/content/public/common/sandboxed_process_launcher_delegate.h b/content/public/common/sandboxed_process_launcher_delegate.h

index 134fc0f58efe42d2d61ae58367fc716129be53c2..f3ddc39c39de02a653fd622e1e475d7ca6437582 100644

--- a/content/public/common/sandboxed_process_launcher_delegate.h

+++ b/content/public/common/sandboxed_process_launcher_delegate.h

@@ -9,10 +9,7 @@

#include "base/files/scoped_file.h"

#include "base/process/process.h"

#include "content/common/content_export.h"

-#if defined(OS_MACOSX)

-#include "content/public/common/sandbox_type_mac.h"

-#endif

+#include "content/public/common/sandbox_type.h"

namespace base {

class FilePath;

@@ -66,13 +63,10 @@ class CONTENT_EXPORT SandboxedProcessLauncherDelegate {

// Return the file descriptor for the IPC channel.

virtual base::ScopedFD TakeIpcFd() = 0;

-#if defined(OS_MACOSX)

- // Gets the Mac SandboxType to enforce on the process. Return

- // SANDBOX_TYPE_INVALID for no sandbox policy.

- virtual SandboxType GetSandboxType();

-#endif

#endif

nasko 2015/06/19 12:18:19 nit: empty line after the #endif, before the comme

Will Harris 2015/06/23 16:21:11 Done, but looks weird now, I couldn't find the sta

+ // Gets the SandboxType to enforce on the process. Return SANDBOX_TYPE_INVALID

nasko 2015/06/19 12:18:20 nit: Returns

Will Harris 2015/06/23 16:21:11 Done.

nasko 2015/06/24 08:04:08 I don't see the changes in this file from the prev

Will Harris 2015/06/24 11:37:09 Sorry, I was going to upload them with the same PS

+ // for no sandbox policy.

+ virtual SandboxType GetSandboxType();

};

} // namespace content