Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 118533004: Revert 242061 "Test Keeping NaCl plugins used in app background ..." (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
scheib
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 242061 "Test Keeping NaCl plugins used in app background ..." Broke this test Mac ASAN 64 Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%2064%20Tests%20%281%29/builds/402 AppBackgroundPageNaClTest.BackgroundKeepaliveActive (run #1): [ RUN ] AppBackgroundPageNaClTest.BackgroundKeepaliveActive [6102,475938816:04:26:31.429668] Native Client module will be loaded at base address 0x000066c200000000 [6104,475938816:04:26:32.535943] Native Client module will be loaded at base address 0x00003d5a00000000 ASAN:SIGSEGV ================================================================= ==6095==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000106384d7b sp 0x7fff5d44fde0 bp 0x7fff5d450000 T0) #0 0x106384d7a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdbd7a) #1 0x106384a31 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdba31) #2 0x11296475a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb75a) #3 0x112964905 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb905) #4 0x1061f4e33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4be33) #5 0x1061f45af (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4b5af) #6 0x1049070ec (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10215e0ec) #7 0x104902b5b (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x102159b5b) #8 0x109457b06 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caeb06) #9 0x109ca6d33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1074fdd33) #10 0x109453876 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caa876) #11 0x10945e99e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106cb599e) #12 0x10944b514 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106ca2514) #13 0x112896341 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1100ed341) #14 0x1061f1486 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a48486) #15 0x106f2bac3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104782ac3) #16 0x106f2e6f0 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1047856f0) #17 0x106f2f63e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10478663e) #18 0x106f438e8 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10479a8e8) #19 0x106f42939 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104799939) #20 0x10645d4e5 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103cb44e5) #21 0x1061ecafe (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43afe) #22 0x11295833d (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101af33d) #23 0x1061ec995 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43995) #24 0x1027ab5c3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1000025c3) #25 0xe AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV ??:0 ?? ==6095==ABORTING > Test Keeping NaCl plugins used in app background pages alive when active. > > Activity in Native Client plugins results in IPC messages > sent to the BrowserPpapiHostImpl and routed to call > extensions::ProcessManager::KeepaliveImpulse. > > Testing patch, builds on implementation. See: > https://codereview.chromium.org/61063003/ Implementation. > https://codereview.chromium.org/105873003/ Cumulative patch. > > Design doc: > https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# > > BUG=298339 > > Review URL: https://codereview.chromium.org/111563006 TBR=scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -311 lines) Patch
M trunk/src/chrome/browser/extensions/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/app_background_page_apitest.cc View 5 chunks +0 lines, -118 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/components/nacl/browser/nacl_process_host.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/extensions/browser/process_manager.h View 2 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/extensions/browser/process_manager.cc View 3 chunks +1 line, -17 lines 0 comments Download
M trunk/src/ppapi/proxy/plugin_main_nacl.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/ppapi/shared_impl/ppapi_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ppapi/shared_impl/ppapi_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/ppapi/tests/extensions/background_keepalive/background.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D trunk/src/ppapi/tests/extensions/background_keepalive/background.js View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/ppapi/tests/extensions/background_keepalive/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
M trunk/src/ppapi/tests/extensions/extensions.gyp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years ago (2013-12-20 17:44:16 UTC) #1
Dan Beam
7 years ago (2013-12-20 17:44:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r242120.

Powered by Google App Engine
This is Rietveld 408576698