Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 118533003: Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2) (Closed)

Created:
7 years ago by bajones
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2) Requires changes from https://codereview.chromium.org/99053007/ before this can be rolled in Chromium DEPS. If this begins breaking the build due to an early roll, please contact bajones@chromium.org before reverting. BUG=326382 TBR=bsalomon@chromium.org Committed: http://code.google.com/p/skia/source/detail?r=12758

Patch Set 1 #

Patch Set 2 : Put change behind a flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years ago (2013-12-18 20:51:14 UTC) #1
bajones
7 years ago (2013-12-18 20:51:54 UTC) #2
bsalomon
On 2013/12/18 20:51:54, bajones wrote: lgtm. BTW Skia DEPS rolls every morning Eastern but you're ...
7 years ago (2013-12-18 20:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bajones@chromium.org/118533003/1
7 years ago (2013-12-18 20:56:58 UTC) #4
commit-bot: I haz the power
Change committed as 12758
7 years ago (2013-12-18 21:09:23 UTC) #5
robertphillips
This was reverted in r12762
7 years ago (2013-12-18 23:57:24 UTC) #6
robertphillips
Brian PTAL.
7 years ago (2013-12-19 19:21:37 UTC) #7
bsalomon
lgtm
7 years ago (2013-12-19 19:23:25 UTC) #8
bajones
Wouldn't it be better to use an "Enable" flag instead of an "Ignore" flag? That ...
7 years ago (2013-12-19 19:30:48 UTC) #9
robertphillips
We always use "ignore" flags so Chromium feels a tiny bit bad about not using ...
7 years ago (2013-12-19 19:32:29 UTC) #10
bajones
On 2013/12/19 19:32:29, robertphillips wrote: > We always use "ignore" flags so Chromium feels a ...
7 years ago (2013-12-19 19:34:56 UTC) #11
robertphillips
Nope - I'll add the flag in tonight's/tomorrow morning's DEPS roll. All you have to ...
7 years ago (2013-12-19 19:36:10 UTC) #12
robertphillips
7 years ago (2013-12-19 19:37:25 UTC) #13
Message was sent while issue was closed.
committed as r12781

Powered by Google App Engine
This is Rietveld 408576698